execution: batch by series optimization for matrix selectors with high window overlap#682
Draft
afhassan wants to merge 1 commit into
Draft
execution: batch by series optimization for matrix selectors with high window overlap#682afhassan wants to merge 1 commit into
afhassan wants to merge 1 commit into
Conversation
Signed-off-by: Ahmed Hassan <afayekhassan@gmail.com>
| // If any aggregate is present in the plan, the batch size is set to the configured value. | ||
| // The two exceptions where this cannot be done is if the aggregate is quantile, or | ||
| // when a binary expression precedes the aggregate. | ||
| func (m SelectorBatchSize) Optimize(plan Node, _ *query.Options) (Node, annotations.Annotations) { |
Contributor
There was a problem hiding this comment.
im not sure this will even reach into ringbuffers, right now this only applies to vectors in direct aggregations i think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explores using a series-batching optimization to reduce peak
RingBuffermemory usage for queries with long lookback windows and high cardinality.Problem: Queries like
sum(increase(metric[24h]))with a small step size create relatively large ring buffer for matrix selectors. This is done once per series and can quickly bloat memory causing OOM for high cardinality queries.Solution: When matrix selector window overlap exceeds a certain number of steps (example 100), the optimizer switches from step batching to series batching:
Changes:
This PR is work in progress... The main blocker is validating that series batching can work for certain functions/operators that need all series present for execution